New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the default shared health check registry name #1095

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
3 participants
@arteam
Member

arteam commented Feb 27, 2017

Add the ability to use a shared health check registry across different modules. The managed health check registry is set via the setDefault method and then it could be accessible by consumers via the getDefault method.

This is aligned with SharedMetricRegistries, which provides the same functionality.

Add support for the default shared health check registry name
Add the ability to use a shared health check registry across different modules.
The managed health check registry is set via the `setDefault` method and
then it could be accessible by consumers via the `getDefault` method.

This is aligned with `SharedMetricRegistries`, which provides the same
functionality.
@arteam

This comment has been minimized.

Show comment
Hide comment
@arteam

arteam Feb 27, 2017

Member

The original idea from @mattnelson in #849

Member

arteam commented Feb 27, 2017

The original idea from @mattnelson in #849

@arteam arteam requested a review from jplock Feb 27, 2017

@arteam arteam added the improvement label Feb 27, 2017

@arteam arteam added this to the 3.2.1 milestone Feb 27, 2017

@jplock

jplock approved these changes Feb 27, 2017

@jplock jplock merged commit cf0013d into 3.2-development Feb 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jplock jplock deleted the shared_health_checks branch Feb 27, 2017

@sata

This comment has been minimized.

Show comment
Hide comment
@sata

sata Feb 28, 2017

@jplock Does the tests work for you?

I get

Expecting empty but was:<["db"]>
at com.codahale.metrics.health.SharedMetricRegistriesTest.clearsRegistries(SharedMetricRegistriesTest.java:52)

Cheers.

sata commented Feb 28, 2017

@jplock Does the tests work for you?

I get

Expecting empty but was:<["db"]>
at com.codahale.metrics.health.SharedMetricRegistriesTest.clearsRegistries(SharedMetricRegistriesTest.java:52)

Cheers.

@jplock

This comment has been minimized.

Show comment
Hide comment
@jplock

jplock Feb 28, 2017

Member

The tests passed on travis.

Member

jplock commented Feb 28, 2017

The tests passed on travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment