New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponentially decaying reservoir update #1135

Merged
merged 8 commits into from Jun 13, 2017

Conversation

Projects
None yet
3 participants
@IstvanM
Contributor

IstvanM commented May 31, 2017

Exponentially Decaying Reservoir was giving incorrect values in the snapshot if the inactive period was too long. This could result in wrong metrics aggregation.

@arteam

This comment has been minimized.

Show comment
Hide comment
@arteam

arteam May 31, 2017

Member

Thanks for the pull request! I will review today.

Member

arteam commented May 31, 2017

Thanks for the pull request! I will review today.

@arteam arteam self-requested a review May 31, 2017

@IstvanM

This comment has been minimized.

Show comment
Hide comment
@IstvanM

IstvanM Jun 1, 2017

Contributor

Thank you! Let me know if you need anything to be changed .

Contributor

IstvanM commented Jun 1, 2017

Thank you! Let me know if you need anything to be changed .

@IstvanM

This comment has been minimized.

Show comment
Hide comment
@IstvanM

IstvanM Jun 13, 2017

Contributor

Should be done, can you check please?

Contributor

IstvanM commented Jun 13, 2017

Should be done, can you check please?

@arteam arteam merged commit 6caa4ad into dropwizard:3.2-development Jun 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arteam

This comment has been minimized.

Show comment
Hide comment
@arteam

arteam Jun 13, 2017

Member

Thank you very much for the contribution!

Member

arteam commented Jun 13, 2017

Thank you very much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment