New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get default health check registry without an exception #1152

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
1 participant
@arteam
Member

arteam commented Jun 28, 2017

Currently, there exists only one method for getting the default health
check registry - getDefault. Unfortunately, it throws an
IllegalStateException if the registry is not set. End users need to
check for this condition. Some users would like avoid using
exceptions for the control flow and would prefer to make a null check
instead catching an exception. For them we provide the tryGetDefault
method which does exactly that.

Add ability to get default health check registry without an exception
Currently, there exists only one method for getting the default health
check registry - `getDefault`. Unfortunately, it throws an
`IllegalStateException` if the registry is not set. End users need to
check for this condition. Some users would like avoid using
exceptions for the control flow and would prefer to make a null check
instead catching an exception. For them we provide the `tryGetDefault`
method which does exactly that.

@arteam arteam merged commit e2238aa into 3.2-development Jun 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@arteam arteam added this to the 3.2.3 milestone Jun 28, 2017

@arteam arteam deleted the try_get_default_health_check_registry branch Jun 28, 2017

@arteam arteam added the improvement label Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment