New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GraphiteReporter rate reporting #1167

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
3 participants
@mgolahi
Contributor

mgolahi commented Jul 24, 2017

Fixing rate reporting when rates are converted to a different TimeUnit. Proper integration can be seen here:

Added unit test for verifying rate conversion.

@jplock jplock added this to the 3.2.4 milestone Jul 24, 2017

@jplock jplock modified the milestones: 3.2.5, 3.2.4 Aug 3, 2017

@arteam arteam merged commit 3725027 into dropwizard:3.2-development Aug 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arteam

This comment has been minimized.

Member

arteam commented Aug 3, 2017

You're absolutely right! It was a regression introduced in fbb266a. Unfortunately, we didn't have a unit test for conversion with a custom rate and this mistake slipped through. Thank you very much for submitting a bugfix and unit test.

@arteam arteam modified the milestones: 3.2.5, 3.2.4 Aug 3, 2017

@arteam arteam added the bug label Aug 3, 2017

arteam added a commit that referenced this pull request Aug 3, 2017

arteam added a commit that referenced this pull request Aug 24, 2017

lucamilanesio pushed a commit to GerritCodeReview/gerrit that referenced this pull request Sep 1, 2017

Upgrade metrics-core to 3.2.4
This release includes a fix for a bug in graphite rate reporting [1].

[1] dropwizard/metrics#1167

Change-Id: I0fac570143b8517321857aed7009ae7755d3fc12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment