Fixing GraphiteReporter rate reporting #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're absolutely right! It was a regression introduced in fbb266a. Unfortunately, we didn't have a unit test for conversion with a custom rate and this mistake slipped through. Thank you very much for submitting a bugfix and unit test. |
arteam
pushed a commit
that referenced
this pull request
Aug 3, 2017
arteam
pushed a commit
that referenced
this pull request
Aug 24, 2017
lucamilanesio
pushed a commit
to GerritCodeReview/gerrit
that referenced
this pull request
Sep 1, 2017
This release includes a fix for a bug in graphite rate reporting [1]. [1] dropwizard/metrics#1167 Change-Id: I0fac570143b8517321857aed7009ae7755d3fc12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixing rate reporting when rates are converted to a different TimeUnit. Proper integration can be seen here:
metrics/metrics-core/src/main/java/com/codahale/metrics/ConsoleReporter.java
Line 277 in d170988
Added unit test for verifying rate conversion.