New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1168 Fix uncaught CancellationException when stopping reporter with … #1170

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
2 participants
@vladimir-bukhtoyarov
Contributor

vladimir-bukhtoyarov commented Jul 28, 2017

Fix uncaught CancellationException when stopping reporter with externally managed executor:

  • Do not try to wait the end of current reporting phase, when stopping reporter with externally managed executor, because JDK ScheduledExecutorService does not provide this feature, and handy implementation of this feature requires big amount of complex concurrent code.
  • Do not mock executors(where sensible) in order to make tests more realistic.
#1168 Fix uncaught CancellationException when stopping reporter with …
…externally managed executor:

- Do not try to wait the end of current reporting phase, when stopping reporter with externally managed executor, because JDK ScheduledExecutorService does not provide this feature, and handy implementation of this feature requires big amount of complex concurrent code.
- Do not mock executors(where sensible) in order to make tests more realistic.

@arteam arteam merged commit 5a35ede into dropwizard:3.2-development Aug 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arteam arteam added this to the 3.2.4 milestone Aug 3, 2017

@arteam arteam added the bug label Aug 3, 2017

@arteam

This comment has been minimized.

Member

arteam commented Aug 3, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment