Support sending Graphite metric attributes as tags #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the GraphiteReporter to optionally send metric attributes as tags instead of using the default dot delimited format. Defaults to the existing behavior, and does not attempt to add tag usage anywhere else within the project. Primarily intended to allow other projects that use the graphite reporter as a library (micrometer) to support graphite tags.
joschi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Problem does this PR solve?
I recently submitted a pull request to micrometer to enable graphite tag support.
Apparently I failed to actually test that end to end, and as @workless discovered in micrometer-metrics/micrometer#2069 the PR I submitted doesn't work due to the metric attributes (e.g.
p999,stddevorm15) appended to the metric name by the dropwizard graphite reporter.For example, a metric with a base name of
my.metric;thing=foowould be sent to graphite asmy.metric;thing=foo.count, modifying the user's intended tag value.Instead, it should be sent to graphite as
my.metric;thing=foo;metricattribute=value.count(or something similar).What does this PR do?
This PR updates the GraphiteReporter to optionally send metric attributes as tags instead of using the default dot delimited format.
Defaults to the existing behavior, and does not attempt to add tag usage anywhere else within the project.
Primarily intended to allow other projects that use the graphite reporter as a library (micrometer) to support graphite tags.