Closed
Conversation
…ake sense when the batches end up needing to be paginated
Contributor
|
Really cool functionality, but I've been declining further modules for the main Metrics distribution. I suggest you run this as your own project. I'll be adding a section in the Metrics documentation with links to related libraries, and this should definitely be in it. |
|
@codahale thanks for the quick response, we'll get this set up as a standalone project. What's the preferred format for sending you links for the upcoming related libraries documentation? |
Contributor
|
Right now there isn't one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a
metrics-libratomodule which adds support for publishing to the Librato Metrics API.It was modeled somewhat after the
GraphiteReporter, though I opted for aBuilderclass for configuration. I also used that module'spom.xmlto guide my own; it seems pretty straight-forward, and everything builds, but it probably deserves scrutiny.Thanks!