From 53f112400f8bb9964a24c1b61284e4d9305e4606 Mon Sep 17 00:00:00 2001
From: Jochen Schalanda <jochen@schalanda.name>
Date: Tue, 30 May 2023 22:44:17 +0200
Subject: [PATCH] Generate metadata for reflection on method parameters

Fixes #3342
---
 .../com/codahale/metrics/ClassMetadataTest.java     | 13 +++++++++++++
 pom.xml                                             |  7 ++-----
 2 files changed, 15 insertions(+), 5 deletions(-)
 create mode 100644 metrics-core/src/test/java/com/codahale/metrics/ClassMetadataTest.java

diff --git a/metrics-core/src/test/java/com/codahale/metrics/ClassMetadataTest.java b/metrics-core/src/test/java/com/codahale/metrics/ClassMetadataTest.java
new file mode 100644
index 0000000000..ab95351e6e
--- /dev/null
+++ b/metrics-core/src/test/java/com/codahale/metrics/ClassMetadataTest.java
@@ -0,0 +1,13 @@
+package com.codahale.metrics;
+
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class ClassMetadataTest {
+    @Test
+    public void testParameterMetadataIsAvailable() throws NoSuchMethodException {
+        assertThat(DefaultSettableGauge.class.getConstructor(Object.class).getParameters())
+                .allSatisfy(parameter -> assertThat(parameter.isNamePresent()).isTrue());
+    }
+}
\ No newline at end of file
diff --git a/pom.xml b/pom.xml
index dee3ee651d..3a69622b91 100644
--- a/pom.xml
+++ b/pom.xml
@@ -146,9 +146,7 @@
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-compiler-plugin</artifactId>
-                        <version>${maven-compiler-plugin.version}</version>
                         <configuration>
-                            <fork>true</fork>
                             <compilerArgs combine.children="append">
                                 <arg>-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${errorprone.javac.version}/javac-${errorprone.javac.version}.jar</arg>
                             </compilerArgs>
@@ -167,9 +165,7 @@
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-compiler-plugin</artifactId>
-                        <version>${maven-compiler-plugin.version}</version>
                         <configuration>
-                            <fork>true</fork>
                             <compilerArgs>
                                 <arg>-Xlint:all</arg>
                                 <arg>-XDcompilePolicy=simple</arg>
@@ -318,10 +314,11 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>${maven-compiler-plugin.version}</version>
                 <configuration>
                     <source>1.8</source>
                     <target>1.8</target>
+                    <fork>true</fork>
+                    <parameters>true</parameters>
                     <showWarnings>true</showWarnings>
                     <compilerArgs>
                         <arg>-Xlint:all</arg>