Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export boolean values to graphite as 1/0 #905

Merged
merged 1 commit into from May 17, 2016

Conversation

@swehner
Copy link

@swehner swehner commented Jan 18, 2016

When exporting metrics from hystrix to graphite (https://github.com/Netflix/Hystrix using https://github.com/Netflix/Hystrix/tree/master/hystrix-contrib/hystrix-codahale-metrics-publisher) we've seen that there are some interesting properties like isCircuitBreakerOpen that are not exported to Graphite.
These properties are boolean values. We think it'd make sense to export them as 0/1 so they can be graphed alongside some other values.

@jplock
Copy link
Member

@jplock jplock commented Apr 7, 2016

Can you add test for this?

@jplock jplock added the improvement label Apr 7, 2016
@jplock jplock added this to the 4.0.0 milestone Apr 20, 2016
@swehner swehner force-pushed the swehner:export-booleans-to-graphite branch from c66b4f3 to 50ac265 May 17, 2016
@swehner
Copy link
Author

@swehner swehner commented May 17, 2016

Hey,

Sorry for the delay - I've added a testcase for this and rebased the branch on top of the master.
Cheers

@ryantenney ryantenney merged commit 24ad83c into dropwizard:master May 17, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryantenney
Copy link
Member

@ryantenney ryantenney commented May 17, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.