New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export boolean values to graphite as 1/0 #905

Merged
merged 1 commit into from May 17, 2016

Conversation

Projects
None yet
4 participants
@swehner

swehner commented Jan 18, 2016

When exporting metrics from hystrix to graphite (https://github.com/Netflix/Hystrix using https://github.com/Netflix/Hystrix/tree/master/hystrix-contrib/hystrix-codahale-metrics-publisher) we've seen that there are some interesting properties like isCircuitBreakerOpen that are not exported to Graphite.
These properties are boolean values. We think it'd make sense to export them as 0/1 so they can be graphed alongside some other values.

@jplock

This comment has been minimized.

Show comment
Hide comment
@jplock

jplock Apr 7, 2016

Member

Can you add test for this?

Member

jplock commented Apr 7, 2016

Can you add test for this?

@jplock jplock added the improvement label Apr 7, 2016

@jplock jplock added this to the 4.0.0 milestone Apr 20, 2016

@swehner

This comment has been minimized.

Show comment
Hide comment
@swehner

swehner May 17, 2016

Hey,

Sorry for the delay - I've added a testcase for this and rebased the branch on top of the master.
Cheers

swehner commented May 17, 2016

Hey,

Sorry for the delay - I've added a testcase for this and rebased the branch on top of the master.
Cheers

@ryantenney ryantenney merged commit 24ad83c into dropwizard:master May 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryantenney

This comment has been minimized.

Show comment
Hide comment
@ryantenney

ryantenney May 17, 2016

Member

Thanks!

Member

ryantenney commented May 17, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment