Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set custom prefix Jetty QueuedThreadPool's metrics #908

Closed
wants to merge 1 commit into from

Conversation

@dagi
Copy link

@dagi dagi commented Jan 19, 2016

Prior to this fix all Jetty QueuedThreadPool's metrics are prefixed
by the class. The fix allows set the metric's name prefix. The origin value is
used as the default value because of backward compatibility. We don't want to
arbitrary chnage the name of metrics once existing users swith to new version of
the library.

Prior to this fix all Jetty QueuedThreadPool's metrics are prefixed
by the class. The fix allows set the metric's name prefix. The origin value is
used as the default value because of backward compatibility. We don't want to
arbitrary chnage the name of metrics once existing users swith to new version of
the library.
@ryantenney ryantenney closed this Jul 12, 2016
@ryantenney ryantenney reopened this Jul 12, 2016
arteam added a commit that referenced this pull request Jan 5, 2017
Prior to this fix all Jetty QueuedThreadPool's metrics are prefixed
by the class. The fix allows set the metric's name prefix. The origin value is
used as the default value because of backward compatibility. We don't want to
arbitrary change the name of metrics once existing users switch to new version of
the library.
@arteam
Copy link
Member

@arteam arteam commented Jan 5, 2017

This was contributed to the 3.2.x branch in #947. But we can use the unit tests from your pull requests.
Applied to the 3.2-development branch as 240fed4. Thank you.

@arteam arteam closed this Jan 5, 2017
@arteam arteam added the improvement label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.