New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting custom prefix in InstrumentedQueuedThreadPool #947

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
3 participants
@krasinski
Contributor

krasinski commented May 6, 2016

Hello,
I want to add ability to set custom prefix in InstrumentedQueuedThreadPool in metrics-jetty9. In similar way to InstrumentedHandler.
I've added setter because I think there should be a simple way to set the prefix when someone wants to use existing defaults. Another way would be adding some additional constructors (obviously I don't want to break the existing api) - but that would bring some other design issues.
I'm not sure what's better - what do you think about it?

@jplock jplock added this to the 3.2.0 milestone May 20, 2016

@arteam

This comment has been minimized.

Show comment
Hide comment
@arteam

arteam Jan 5, 2017

Member

Looks good to me. I like the setter approach.

Member

arteam commented Jan 5, 2017

Looks good to me. I like the setter approach.

@arteam arteam merged commit 511eae0 into dropwizard:3.2-development Jan 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arteam

This comment has been minimized.

Show comment
Hide comment
@arteam

arteam Jan 5, 2017

Member

Thanks for the contribution!

Member

arteam commented Jan 5, 2017

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment