Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Better handling of keyboard navigation to be "accessible"? #26
As the term "accessible" is being used here, it's worth noting that ideally the modal should handle keyboard navigation a bit better - if it acts as a true modal, users that navigate via keyboard should, after opening the modal, only be able to tab/shift+tab through the links/elements of the modal itself until it's closed. this will require some additional JS to set initial focus into the modal, make sure that focus stays/cycles within the modal itself, and is returned back to the main page after the modal is closed.
Thanks for the comment and thoughts, Patrick.
The modal is focused when opening it. Please see this line and the
I tried to focus back on the main page when the modal is closed here. I might have to look into restoring the original focus state on the actual element instead of the body element which happens in Chrome.
An update for the cycling should definitely be implemented.