browsersync should default to HTTPS, fixes #19

[tyler36]

Fixes

• The addon is not working properly even with basic projects based on the HTTP protocol #19

Currently, browsersync is configured to run on the HTTP. This is not optimal.

This PR changes browsersync to use the HTTPS protocal instead.

Note: When starting browsersync, it reports the "External URL" has HTTP. I tried adding HTTPS: true to the config file but this resulted in a broken DDEV (502)

[rfay]

Does this mean you figured it out, or that you still couldn't make it work on https?

[tyler36]

This is working locally for me.

[tyler36]

Browsersync is running on HTTPS protocal in the browser. The CLI reports to running on HTTP though. It would be nice to have that correct but I think it might be the reverse proxy stuff?

[rfay]

Looks like maybe some work remaining to do on tests?

[rfay]

Well, it definitely works, but it will be too confusing to people.

Could we at least change ddev browsersync command to output the true information? Maybe it can say at the top, before launching browsersync "IT WILL BE HTTP NOT HTTP" :) and give a good URL. It might be possible to do something more sophisticated than that.

I think you already know that the reason it won't work by telling browsersync to use https is that then the ddev-router can't trust (or even decrypt) the https content.

So the problem is just that we're letting browsersync provide inadequate information, and we need to figure out a way around that.

I think it would be good to add more to the README about editing browser-sync.js as well. And how about adding "web" as one of the listed items/

[ADDISON74]

I did the changes to expose the new ports in docker-compose.browsersync.yaml. Here are the test results for different scenarios.

1 - Opening https://browsersync.ddev.site:3000 in the browser. As you may see any changes in the index.html file are loaded in the browser window.

2 - By opening http://browsersync.ddev.site:3000 in the browser (the BrowserSync External link) we get a 400 error.

3 - By opening http://browsersync.ddev.site in the browser (the DDEV link using HTTP protocol) BrowserSync detects the changes in the file but it is not reloading the browser window content.

In order to display https instead of http in the External link of the BrowserSync console we should add this option https: true in the browser-sync.js file, but if we do this you may see what happens bellow. BrowserSync detects the changes in the index.html file, but accessing the External link in the browser produces a 502 error.

As a first conclusion after these scenarios. Changing the ports was beneficial, now the addon can also be used with HTTPS. The issue that needs to be solved is related to the External link displayed by BrowserSync in the console and which creates confusion but also errors in the situation in which it is used.

[tyler36]

Not sure why the tests are failing :(

[rfay]

FYI it's worth thinking about allowing HTTPS communication between ddev-webserver and ddev-router, but that wouldn't fundamentally solve the problem here, because the bound port (443) by default might be changed.

Thanks for all the work on this.

[rfay]

This PR can be tested with ddev get https://github.com/tyler36/ddev-browsersync/tarball/tyler36/https-support/

[ursbraem]

I got the PR and encountered no issues so far

[mandrasch]

This PR can be tested with ddev get https://github.com/tyler36/ddev-browsersync/tarball/tyler36/https-support/

Used it in this demo repo: https://github.com/mandrasch/ddev-laravelmix-browsersync, worked fine (quick test).

[rfay]

Doggone those tests :)

[rfay]

Will definitely review and take a look at tests. Just under the gun to get the traefik stuff done for a major release. Thanks for your patience!

[rfay]

Thanks so much for the good work on this. Please take a look at

• https-support PR: Make it report the right URL, improve tests #31

and if you're OK with it, merge it in here.

[tyler36]

Closing this in favor of #31

[tyler36]

Sorry. #31 was a PR to this PR. Re-opening.