Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and try to fix most annoying repetitive test failures #1270

Closed
rfay opened this issue Nov 16, 2018 · 2 comments
Closed

Review and try to fix most annoying repetitive test failures #1270

rfay opened this issue Nov 16, 2018 · 2 comments

Comments

@rfay
Copy link
Member

rfay commented Nov 16, 2018

Is your feature request related to a problem? Please describe.

We have some test failures that we end up retrying over and over again; they waste our time and testing time. See spreadsheet. Let's get rid of the worst ones.

Describe the solution you'd like

  • Fix line 5 (TestConfigOverrideDetection) on madOS. This one is an obvious cleanup flaw, and when it fails it leaves a broken testbot.
  • Fix line 2 (TestDevListContinuous) on macOS. It shouldn't be hard as it isn't happening on other platforms.
  • php-fpm SIGBUS cases failures in TestDdevLogs (Iine 8) and TestDdevRestoreSnapshot (line 4), both only on macOS. Although we don't know how to fix the underlying error with php-fpm, there should be a workaround. (Try again on 502 error???)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

rfay added a commit to rfay/ddev that referenced this issue Nov 24, 2018
rfay added a commit that referenced this issue Dec 2, 2018
…#1270 (#1316)

* Add debug log for web log on app.Start fail; removes some unuseful debug stuff
* Improve logs capture for reporting in error handling
* Rewrite TestDdevListContinuous so it actually works
* Remove unuseful http match log
* Speed up TestComposerCmd a bit more by using smaller packages
* Add logs on fail of TestDescribeMissingDirectory
* Add logs on TestGetLocalHTTPResponse
* Speed up web container test by using smaller composer build
@rfay
Copy link
Member Author

rfay commented Dec 12, 2018

We've made significant progress on this. If we can kill the one in TestConfigOVerrideDetection, the most annoying current remaining one is mkdir /c failed in the windows builds.

@rfay
Copy link
Member Author

rfay commented Jan 8, 2019

This one becomes an ongoing struggle. We've improved a lot of things. My strategy at this point is to try to append test fixes onto the PR where they fail instead of just retrying them multiple times.

@rfay rfay closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants