Inspect mysql version before failing when restoring a snapshot, #1170 #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfrench
changed the title
rfay
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#1170
How this PR Solves The Problem:
This allows the snapshot error help text method of recovery to work by inspecting the mysql version currently being used and only failing if the current database version requires the
db_mariadb_version.txtfile to exist.Manual Testing Instructions:
ddev snapshotddev rmddev configddev startddev restore-snapshot <snapshot>; this will fail - below are the steps recommended in the help linkddev rmddev restore-snapshot <snapshot>; this should succeedddev rmddev startddev logs -s dbwill show "Running mysql_upgrade"Automated Testing Overview:
Related Issue Link(s):
#1170