New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide mariadb 10.1 and 10.2, fixes #1221 #1318

Merged
merged 21 commits into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@rfay
Copy link
Member

rfay commented Dec 3, 2018

The Problem/Issue/Bug:

It turns out TYPO3 v8 and earlier require Mariadb 10.1 and can't function with 10.2. This PR provides explicit 10.1 support.

The first attempt at this was #1222, which tried it using library/mariadb, but that made images that were twice as big and swich to debian base image. Too much change for too little value. This one maintains two almost identical images.

How this PR Solves The Problem:

  • 10.1 and 10.2 are now available with setting mariadb_version: 10.1 etc in config.yaml
  • You can also ddev config --mariadb-version=10.1 and ddev start.
  • You can also restore 10.1 snapshots (pre v1.3) with it running in 10.1 mode.
  • An attempt to start a 10.2 database with 10.1 mariaDB will fail and the logs will tell why (and it fails before the db can be damaged).
  • An attempt to restore a 10.1 snapshot with 10.2 is warned.
  • An attempt to restore a 10.2 snapshot with 10.1 is warned.

Manual Testing Instructions:

To test out the mariadb 10.1 db, please:
• dump your db to make a backup: ddev export-db >dump.sql.gz
ddev remove --remove-data which will create an automatic snapshot also (or ddev remove --remove-data --omit-snapshot if you don't want it.
ddev config --mariadb-version=10.1
ddev start

Automated Testing Overview:

  • There's a new test just for 10.1 that goes over the basics of database usage.

Related Issue Link(s):

OP #1221

Release/Deployment notes:

@rfay rfay added this to the v1.5.0 milestone Dec 3, 2018

@rfay rfay self-assigned this Dec 3, 2018

@rfay rfay force-pushed the rfay:20181203_mariadb_2_versions branch from 32b0c77 to 8187b4a Dec 3, 2018

@rfay rfay force-pushed the rfay:20181203_mariadb_2_versions branch from 8187b4a to a2ec561 Dec 11, 2018

@rfay rfay force-pushed the rfay:20181203_mariadb_2_versions branch from a2ec561 to a4a596b Dec 12, 2018

@rfay rfay requested a review from andrewfrench Dec 12, 2018

@rfay

This comment has been minimized.

Copy link
Member

rfay commented Dec 12, 2018

I didn't mean to put so much effort into this, but am pretty happy with the end result. It even has error checking on wrong-db-version and wrong-snapshot type. Even though the audience is probably small, they'll appreciate it. And we have enough test coverage for it I think. And if we're forced to add another type, the model is at least in place.

@andrewfrench
Copy link
Member

andrewfrench left a comment

Switching MariaDB versions through config.yaml was successful for 10.1 and 10.2 as reported by ddev exec -s db mysql --version.

With a project/database created using ddev v1.4.0 (MariaDB 10.2), downgrading to MariaDB 10.1 caused ddev start to fail, with a log message about incompatible versioning (ddev logs -s db).

Exporting the database (ddev export-db > ~/dump.sql.gz), downgrading from MariaDB 10.2 to 10.1, removing the database (ddev remove --remove-data --omit-snaphot), then importing the exported database (ddev import-db --src ~/dump.sql.gz) was successful.

@rfay rfay merged commit d6842dc into drud:master Dec 13, 2018

8 checks passed

buildkite/ddev-containers-macos Build #1202 passed (32 minutes, 21 seconds)
Details
buildkite/ddev-containers-windows Build #1062 passed (3 hours, 2 minutes, 54 seconds)
Details
buildkite/ddev-macos Build #1448 passed (28 minutes, 12 seconds)
Details
buildkite/ddev-macos-use-webcache Build #53 passed (1 hour, 28 minutes, 34 seconds)
Details
buildkite/ddev-windows-apache-fpm Build #630 passed (1 hour, 15 minutes, 32 seconds)
Details
buildkite/ddev-windows-dockerforwindows Build #1533 passed (1 hour, 48 minutes, 17 seconds)
Details
buildkite/ddev-windows-dockertoolbox Build #1208 passed (40 minutes, 29 seconds)
Details
license/cla Contributor License Agreement is signed.
Details

@rfay rfay deleted the rfay:20181203_mariadb_2_versions branch Dec 13, 2018

@rfay rfay referenced this pull request Dec 13, 2018

Closed

v1.5.0 Release Checklist Due 2018-12-18 #1293

8 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment