Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use pv to show progress bar during import-db #1349
There is no feedback during long running database imports.
How this PR Solves The Problem:
This PR uses
Manual Testing Instructions:
Automated Testing Overview:
Changes are visual only, and require a tty, so automated testing is quite tricky.
Related Issue Link(s):
Automated processes that use
The tests fail because they are not connected to a tty, so it looks like I need to use github.com/mattn/go-isatty to detect whether stdout is a tty or not, and call
What we have to do is push a new version of the container, and update in pkg/version/version.go with the new version. I just pushed drud/ddev-dbserver:20190103_import-db-progress-10.1 and drud/ddev-dbserver:20190103_import-db-progress-10.2, please add a commit to pkg/version/version.go that updates the version there (temporarily, until next release), and then you'll get the right container.
rfay left a comment
I rebased and tested this with a largish db on macOS; it worked fine with both