Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve curl commands so they fail when they should on build #1451

merged 2 commits into from Feb 15, 2019


None yet
1 participant
Copy link

commented Feb 13, 2019

The Problem/Issue/Bug:

On the nightly build last night we had an issue where nssm was not downloading properly. But the failure was in the unzip, and it should have been on the download. This adds -f or --fail to the various curls used in the build process.

In passing, also:

  • Moves docker-compose to brew install
  • Minor change to ghr download technique

How this PR Solves The Problem:

Manual Testing Instructions:

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@rfay rfay force-pushed the rfay:20190213_make_curl_fail_properly branch from c80f967 to 2d8f76d Feb 13, 2019

@rfay rfay force-pushed the rfay:20190213_make_curl_fail_properly branch from 2d8f76d to 4f8d920 Feb 13, 2019

@rfay rfay merged commit 23d8d36 into drud:master Feb 15, 2019

8 checks passed

buildkite/ddev-containers-windows Build #1455 passed (49 minutes, 20 seconds)
buildkite/ddev-windows-apache-fpm Build #1023 passed (1 hour, 36 minutes, 5 seconds)
buildkite/ddev-windows-dockerforwindows Build #1993 passed (3 hours, 56 minutes, 34 seconds)
buildkite/ddev-windows-dockerforwindows-nfs Build #138 passed (1 hour, 49 minutes, 36 seconds)
buildkite/ddev-windows-dockertoolbox Build #1600 passed (53 minutes, 47 seconds)
buildkite/ddev-windows-dockertoolbox-nfs Build #136 passed (47 minutes, 44 seconds)
license/cla Contributor License Agreement is signed.
normal_build_and_test Workflow: normal_build_and_test

@rfay rfay deleted the rfay:20190213_make_curl_fail_properly branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.