Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
ddev-webserver Nginx - do not intercept 400 errors #1555
The issue is that currently Nginx swallows all the upstream error messages. This is particularly painful for instance for webservices where the error message would be crucial to get in addition to the status code.
How this PR Solves The Problem:
It changes the default configuration of Nginx to pass all the upstream errors.
Manual Testing Instructions:
Put a tiny PHP script inside the container:
header($_SERVER['SERVER_PROTOCOL'] . ' 500 Internal Server Error', true, 500); echo "moo";
Automated Testing Overview:
Right now the PR does not contain tests, if it's approved that it's a wanted change, it should have a test that contains a dummy script that provides error and it tries to access that URL via
DDEV users need to be warned that the default behavior changes, it alters the behaviors of the applications in case of HTTP error responses.
Related: #1367 (comment) neos needed this change.