New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux homebrew-ddev for v1.5.1, bottles, and source build capability, fixes #1 #31

Merged
merged 7 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@rfay
Copy link
Member

rfay commented Jan 10, 2019

This PR fixes longstanding issue #1 and adds the

  • ability to build from source (brew install --build-from-source ddev)
  • build bottles (see readme)
  • Download from bottles on dl.bintray.com
  • LINUX support for Linuxbrew!

Manual testing before pull:

  • brew uninstall --force ddev
  • brew tap rfay/ddev
  • brew install ddev (on both linux and macOS)
  • brew install --build-from-source (on both linux and macOS)
  • Verify correct behavior of ddev binary.
  • Review README.md

@rfay rfay self-assigned this Jan 10, 2019

@rfay rfay requested a review from andrewfrench Jan 10, 2019

@rfay rfay changed the title Linux homebrew-ddev for v1.5.1, bottles, and source build capability Linux homebrew-ddev for v1.5.1, bottles, and source build capability, fixes #1 Jan 12, 2019

@andrewfrench
Copy link
Member

andrewfrench left a comment

Linux (Ubuntu)

$ brew uninstall --force ddev
$ brew tap rfay/ddev
$ brew install rfay/ddev/ddev

ddev is installed successfully

$ brew uninstall --force ddev
$ brew install --build-from-source rfay/ddev/ddev

⚠️ This generally looks good. The logs imply that it's trying to install Docker as a dependency, but Docker must be running for make linux.

Darwin (macOS 10.14)

$ brew uninstall --force ddev 
$ brew tap rfay/ddev
$ brew install rfay/ddev/ddev

Downloads v1.5.1 from Bintray and installs successfully

$ brew uninstall --force ddev
$ brew install --build-from-source rfay/ddev/ddev

⚠️ Similarly, if Docker is not installed/running, this fails. When Docker is running, all is good.

@rfay rfay merged commit bc44273 into drud:master Jan 14, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@rfay rfay deleted the rfay:20190109_homebrew_full_build branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment