Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a non-zero exit code when error in command parsing #3137

Merged
merged 1 commit into from Jun 14, 2016

Conversation

drcrallen
Copy link
Contributor

This is helpful for things like automated build scripts that should fail if a command syntax changes, and the script does not notice. Without this change a script may think the command completed successfully.

@drcrallen drcrallen added this to the 0.9.2 milestone Jun 13, 2016
@gianm
Copy link
Contributor

gianm commented Jun 13, 2016

👍

@drcrallen
Copy link
Contributor Author

Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 67.041 sec <<< FAILURE! - in io.druid.curator.announcement.AnnouncerTest
testSanity(io.druid.curator.announcement.AnnouncerTest)  Time elapsed: 61.047 sec  <<< ERROR!
java.lang.Exception: test timed out after 60000 milliseconds
    at sun.misc.Unsafe.park(Native Method)
    at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:226)
    at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1033)
    at java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1326)
    at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:282)
    at org.apache.curator.test.Timing.awaitLatch(Timing.java:120)
    at io.druid.curator.announcement.AnnouncerTest.testSanity(AnnouncerTest.java:101)

@drcrallen drcrallen closed this Jun 13, 2016
@drcrallen drcrallen reopened this Jun 13, 2016
@fjy
Copy link
Contributor

fjy commented Jun 14, 2016

👍

@fjy fjy merged commit e7ac2e8 into apache:master Jun 14, 2016
@drcrallen drcrallen deleted the erroSetsNonZeroExit branch June 14, 2016 14:30
seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants