Enable auto license checking #3836

merged 2 commits into from Jan 11, 2017


None yet

3 participants

jihoonson commented Jan 10, 2017 edited

This patch contains a bunch of changes for license headers of java files. Key changes are:

  • Added LICENSE.txt to codestyle directory.
  • Added <headerLocation>codestyle/LICENSE.txt</headerLocation> to {project.root}/pom.xml
  • Added the following contents to checkstyle.xml
<module name="Header">
    <property name="headerFile" value="${checkstyle.header.file}"/>
    <property name="fileExtensions" value="java"/>
  • Added <suppress checks="Header" files="[\\/]target[\\/]generated-test-sources[\\/]" /> to checkstyle-suppressions.xml

This change is Reviewable

gianm commented Jan 10, 2017

Thanks @jihoonson, more checkstyles are more better!

I reviewed the changes ignoring whitespace (https://github.com/druid-io/druid/pull/3836/files?w=1) and it looks like other than whitespace, mostly you are adding headers to files that miss them, and changing the old style headers in druid-api to new style headers. That's good, since we just moved them in a while back without updating the headers.

Could you please fix the headers on SQLServerConnector.java, BoundDimFilterTest.java, SQLMetadataRuleManager.java, and SQLMetadataSegmentPublisher.java? They all have two headers now.

After that the change LGTM

@gianm gianm added this to the 0.10.0 milestone Jan 10, 2017
@gianm gianm added the Improvement label Jan 10, 2017
fjy commented Jan 10, 2017

👍 from me after addressing @gianm's comment


@gianm, @fjy thank you for your review. I fixed it.

gianm approved these changes Jan 11, 2017 View changes


@fjy fjy merged commit d80bec8 into druid-io:master Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment