TmpFileIOPeons to create files under the merging output directory, instead of java.io.tmpdir #3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tput directory/tmpPeonFiles, instead of java.io.tmpdir
drcrallen
requested changes
Mar 2, 2017
| v8OutDir.mkdirs(); | ||
| registerDeleteDirectory(closer, v8OutDir); | ||
| File tmpPeonFilesDir = new File(v8OutDir, "tmpPeonFiles"); | ||
| tmpPeonFilesDir.mkdir(); |
There was a problem hiding this comment.
This will pass even if the directory is not created. Is that intended?
There was a problem hiding this comment.
Used FileUtils.forceMkdir() here and in some other places in the codebase
|
This changes a few |
drcrallen
approved these changes
Mar 2, 2017
gianm
approved these changes
Mar 2, 2017
| registerDeleteDirectory(closer, v8OutDir); | ||
| File tmpPeonFilesDir = new File(v8OutDir, "tmpPeonFiles"); | ||
| FileUtils.forceMkdir(tmpPeonFilesDir); | ||
| registerDeleteDirectory(closer, tmpPeonFilesDir); |
There was a problem hiding this comment.
No reason to register a delete directory for this, it's contained within v8OutDir which is already registered.
There was a problem hiding this comment.
It's harmless and makes the code a little more "self-contained", if tmpPeonFilesDir if moved somewhere else (out of v8OutDir), so I would keep these calls
|
|
||
| File tmpPeonFilesDir = new File(v9TmpDir, "tmpPeonFiles"); | ||
| FileUtils.forceMkdir(tmpPeonFilesDir); | ||
| registerDeleteDirectory(closer, tmpPeonFilesDir); |
There was a problem hiding this comment.
No reason to register deletion of this, it's contained within v9TmpDir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made
IndexMergerandIndexMergerV9to create temporary files under the output directory +/tmpPeonFiles, instead ofjava.io.tmpdir.This is needed to make it possible to point
java.io.tmpdirto/tmp, and mount/tmpon tmpfs. Read the story about why keeping/tmpmounted on real disk is bad on boxes which run JVMs. https://issues.apache.org/jira/browse/CASSANDRA-9242 and https://groups.google.com/d/msg/mechanical-sympathy/9SP4IM-MUrI/mVZEK2cWDQAJ are also relevant.Just mounting
/tmpon tmpfs (without this change) makesTmpFileIOPeonpointless, because it exists to load some data off-memory.