feat: LDP-2540: Drupal logout helper function (D10.3+) #27
Conversation
junkuncz
changed the title
tests/helpers/drupal-commands.js
Outdated
| // Logout has a confirmation page since Drupal 10.3. | ||
| await page.locator('input[value="Log out"]').click(); | ||
| }, | ||
|
|
There was a problem hiding this comment.
This is not a (drush) command, so it does not belong in drupal-commands.js.
It should be in test-methods.js, probably close to iLoginAs() -- and probably named iLogOut. (I don't necessarily agree with the naming, but at least it's consistent?(
There was a problem hiding this comment.
Right... I was "blind". Moved it to the correct place and renamed.
| await expect(page.locator('form.user-login-form')).toBeVisible; | ||
| await page.locator('input[name="name"]').fill(username); | ||
| await page.locator('input[name="pass"]').fill(process.env.APP_SECRET); | ||
| await page.locator('input[value="Log in"]').click(); |
There was a problem hiding this comment.
Not strictly related to the Drupal Logout, but this seemed a good time to do some refactoring of ILogInAs.
The extra expect() doesn't really add anything, because if we are already logged in, the fill() would also fail.
It's just that the expect() likely generates a better error message.
(Also, I felt I needed to do something, while removing the first line from all the following constructions in the tests:
await helpers.IShouldNotBeLoggedIn(page);
await helpers.ILogInAs([page, 'dru_editor']);
)
rmuit
changed the title
No description provided.