Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor .env files and suggest usage #351

Merged
merged 4 commits into from Mar 16, 2018

Conversation

Projects
None yet
3 participants
@weitzman
Copy link
Collaborator

commented Feb 9, 2018

No description provided.

weitzman added some commits Feb 9, 2018

webflo added some commits Mar 16, 2018

@webflo webflo merged commit 1665375 into 8.x Mar 16, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@webflo webflo deleted the DotEnv branch Mar 16, 2018

@webflo

This comment has been minimized.

Copy link
Member

commented Mar 16, 2018

Thanks @weitzman this is a great addition especially the DRUSH_OPTIONS_URI trick. 👍

@sharique

This comment has been minimized.

Copy link

commented Mar 28, 2018

This is really good feature, can we have some documentation, like how we can use these files for deployment?

@weitzman

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 28, 2018

Deployment is very site specific and I cant think of any generic docs we can add for it. Do you have anything in mind?

@sharique

This comment has been minimized.

Copy link

commented Mar 29, 2018

Let's say I've created 1 .env file for each environment (like .env.local and .env.dev etc..),
So what other steps I need to perform before running "composer install", so that based on environment I get updated settings.php file ready to use. Or what additional parameter I need to pass to "composer install " so that it can generate appropriate settings.php.

@weitzman

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 29, 2018

composer install only downloads your codebase. It doesn't install drupal. Thats a one time step, unlike composer install/update.

You edit your settings.php by hand to add calls to getenv(). See this PR for examples.

seth-shaw-unlv added a commit to Islandora-CLAW/drupal-project that referenced this pull request May 29, 2018

Merge from upstream, fix scaffolding issue (#18)
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Composer lock from PHP 5.6

* Removing drupal-scaffold from the post-* commands

daften pushed a commit to digipolisgent/drupal8_project_template that referenced this pull request Aug 9, 2018

Blomme Dieter
Merge remote-tracking branch 'upstream/8.x' into 8.x
* upstream/8.x: (22 commits)
  Remove unused use statement. (drupal-composer#406)
  Fix typo in README.md
  Remove "drupal-scaffold" from scripts (drupal-composer#275)
  Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)
  Fix tests on Travis CI (drupal-composer#405)
  Update drupal-composer/drupal-scaffold
  Fix installer path for drush commandfiles.
  Bump minimal version to 8.5.3
  Bump minimal version
  Updated argument name
  Remove extra whitespace (drupal-composer#371)
  Honor .env files and suggest usage (drupal-composer#351)
  Improve update instructions (drupal-composer#366)
  Run tests with 8.6.x
  Update to Drupal 8.5
  Add platform version to FAQ to help user specifying PHP version, fixes drupal-composer#359. (drupal-composer#360)
  Update /drush dir for Drush9 (drupal-composer#350)
  Revert "Update /drush dir for Drush9"
  Update /drush dir for Drush9
  Replace require-dev with webflo/drupal-core-require-dev (drupal-composer#348)
  ...

# Conflicts:
#	.gitignore
#	composer.json
#	drush/policy.drush.inc

Natkeeran added a commit to Islandora-CLAW/drupal-project that referenced this pull request Sep 17, 2018

Drupal 8.6 (#23)
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Updating lock file

* Adding drupal-scaffold back in so it works with a lockfile

* drupal-scaffold is now @composer drupal:scaffold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.