Permalink
Browse files

Issue #1504522 by rahulbile, Chi: Strict warning: Only variables shou…

…ld be passed by reference in update_results_page().
  • Loading branch information...
DavidRothstein committed Dec 27, 2013
1 parent 663d464 commit bb746492d200122566557937aeb4bc7e7d20f6cc
Showing with 2 additions and 1 deletion.
  1. +2 −1 update.php
View
@@ -178,7 +178,8 @@ function update_results_page() {
$output = '<p>Updates were attempted. If you see no failures below, you may proceed happily back to your <a href="' . base_path() . '">site</a>. Otherwise, you may need to update your database manually.' . $log_message . '</p>';
}
else {
- list($module, $version) = array_pop(reset($_SESSION['updates_remaining']));
+ $updates_remaining = reset($_SESSION['updates_remaining']);
+ list($module, $version) = array_pop($updates_remaining);
$output = '<p class="error">The update process was aborted prematurely while running <strong>update #' . $version . ' in ' . $module . '.module</strong>.' . $log_message;
if (module_exists('dblog')) {
$output .= ' You may need to check the <code>watchdog</code> database table manually.';

0 comments on commit bb74649

Please sign in to comment.