Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Composer 2 #10

Closed
bobdenotter opened this issue Jun 16, 2020 · 7 comments
Closed

Update for Composer 2 #10

bobdenotter opened this issue Jun 16, 2020 · 7 comments

Comments

@bobdenotter
Copy link
Contributor

Hi @drupol,

Is an update for Composer v2 being planned? (It seems to be the only dependency before we can make Bolt 4 compatible with Composer 2)

@drupol
Copy link
Owner

drupol commented Jun 16, 2020

Hello,

Yes it's in my todo list! I saw that Composer 2 is doing something similar, but I have to check in depth.

I will try to work on a new branch asap.

@bobdenotter
Copy link
Contributor Author

Great to hear! Thanks in advance! :-)

@drupol
Copy link
Owner

drupol commented Jun 18, 2020

Hello,

I pushed a commit that should fix the Composer 2 compatibility.

It's just a first shot, but it could be nice if you could already provide some feedback.

Thanks!

@bobdenotter
Copy link
Contributor Author

The changes look good at first glance, as far as i can tell.. I've not been able to try it in Bolt itself just yet, because other libraries wouldn't install on Composer 2. I'll keep an eye on it, and let you know my findings!

@drupol
Copy link
Owner

drupol commented Jun 18, 2020

Ok I'll wait then :-)

@drupol
Copy link
Owner

drupol commented Oct 24, 2020

I guess this issue could be closed? WDYT @bobdenotter ?

@bobdenotter
Copy link
Contributor Author

Yup, let's close this one as "resolved". :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants