Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updrush make --overwrite should respect --projects=? #1269
Comments
weitzman
added
the
area-make
label
Mar 24, 2015
This comment has been minimized.
This comment has been minimized.
Hello, just wondering if there's any idea on this or if can be put in a roadmap. I am now manually removing directories before running make of projects but I would rather rely on drush. I tried to work on this tu submit a PR but I couldn't find a way to only overwrite what was download and also making sure that it won't break existing functionality. At one point, I had an idea of storing downloaded paths right on I then tried to rely on a temp file but all "drush" ways of storing data on a temp file rely on passing data to child processes, not to parent processes. I could hack my way around it by custom code but probably not the way to go. While I am writing this, I thought of another alternative, which is to have DrushMakeProject::make() put a hidden file in the project top level dir, like .drush-make-toplevel or something like that, then I might try to give that idea a try, but if you share any points, ideas, etc. will be greatly appreciated. |
This comment has been minimized.
This comment has been minimized.
Make is maintenance only; closing. |
hanoii commentedMar 19, 2015
I like the fact that --overwrite removes files that are no longer in the modules, as opposed to the default merge, however, I just found out that if you run --overwrite with some specific --projects=.. it also removes everything else from your contrib destinations, like if you do --projects=rules --overwrite, it will properly process the makefile for rules, but removes everything else. Is it by design or a bug? If the former, is there a way for me to make sure the new download removes anything that's not there?