New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test.drush.inc #1362

Closed
weitzman opened this Issue May 1, 2015 · 7 comments

Comments

Projects
None yet
7 participants
@weitzman
Member

weitzman commented May 1, 2015

Drush attempts to offer an alternative Simpletest runner, mimicking what Drupal's scripts/run-tests.sh offers. Alas hardly anyone keeps it up to date and it has fallen behind for Drupal 8 (can't run phpunit based tests). I propose to remove this script in Drush 7. Others who care can maintain it in Contrib or on Github. Note that run-tests.sh also returns results in junit xml.

Objections?

@greg-1-anderson

This comment has been minimized.

Show comment
Hide comment
@greg-1-anderson

greg-1-anderson May 4, 2015

Member

No objection here. I think it is better to have just one way to run the tests. I think that the Drupal Simpletests are already too fragile--maintaining a parallel runner does not improve the situation, and adds uncertainty.

Member

greg-1-anderson commented May 4, 2015

No objection here. I think it is better to have just one way to run the tests. I think that the Drupal Simpletests are already too fragile--maintaining a parallel runner does not improve the situation, and adds uncertainty.

@amateescu

This comment has been minimized.

Show comment
Hide comment
@amateescu

amateescu May 5, 2015

+1 for removing it.

+1 for removing it.

@weitzman weitzman closed this in b765d33 May 5, 2015

pfrenssen added a commit to pfrenssen/invoicing that referenced this issue May 7, 2015

Issue #IN-43: Run tests through run-tests.sh.
The option to run tests using Drush has been removed.
See drush-ops/drush#1362
@arildm

This comment has been minimized.

Show comment
Hide comment
@arildm

arildm Jun 17, 2015

Any chance we can restore test-clean? It was helpful.

arildm commented Jun 17, 2015

Any chance we can restore test-clean? It was helpful.

@weitzman

This comment has been minimized.

Show comment
Hide comment
@weitzman

weitzman Jun 17, 2015

Member

Sorry, no. Use scripts/run-tests.sh in drupal.

Member

weitzman commented Jun 17, 2015

Sorry, no. Use scripts/run-tests.sh in drupal.

@EugenMayer

This comment has been minimized.

Show comment
Hide comment
@EugenMayer

EugenMayer Jun 30, 2015

that means, i cannot use drush 7.x to run simpletests under drupal6, right?

that means, i cannot use drush 7.x to run simpletests under drupal6, right?

@zikphil

This comment has been minimized.

Show comment
Hide comment
@zikphil

zikphil Oct 29, 2015

Sadly, run-tests.sh does not let you export test result using --xml='path'. Which makes it that much harder to get a proper CI analysis.

zikphil commented Oct 29, 2015

Sadly, run-tests.sh does not let you export test result using --xml='path'. Which makes it that much harder to get a proper CI analysis.

@stefgosselin

This comment has been minimized.

Show comment
Hide comment
@stefgosselin

stefgosselin Oct 30, 2015

@philippelabat - I hit the same wall as you, but came to realise run-tests.sh does support xml exports, it is just not documented in the script arguments.

See line 145 of run-tests.sh

@philippelabat - I hit the same wall as you, but came to realise run-tests.sh does support xml exports, it is just not documented in the script arguments.

See line 145 of run-tests.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment