Bring l10n_update commands in Drush core #139

Closed
penyaskito opened this Issue Sep 22, 2013 · 10 comments

Comments

Projects
None yet
5 participants
@weitzman

This comment has been minimized.

Show comment
Hide comment
@weitzman

weitzman Oct 21, 2013

Member

I'd prefer that these commands mature in Contrib for a bit. Lets revisit this soon before Drush 6 is released.

Member

weitzman commented Oct 21, 2013

I'd prefer that these commands mature in Contrib for a bit. Lets revisit this soon before Drush 6 is released.

@weitzman weitzman closed this Oct 21, 2013

@goba

This comment has been minimized.

Show comment
Hide comment
@goba

goba Jan 21, 2015

Is there an up to date issue on this one? What is the Drupal 8 translation update support status?

goba commented Jan 21, 2015

Is there an up to date issue on this one? What is the Drupal 8 translation update support status?

@goba

This comment has been minimized.

Show comment
Hide comment
@goba

goba Oct 14, 2015

Is there an up to date issue on this one? What is the Drupal 8 translation update support status?

goba commented Oct 14, 2015

Is there an up to date issue on this one? What is the Drupal 8 translation update support status?

@penyaskito

This comment has been minimized.

Show comment
Hide comment
@penyaskito

penyaskito Oct 14, 2015

Contributor

Nothing that I'm aware of. There is https://github.com/dawehner/drush_language though

Contributor

penyaskito commented Oct 14, 2015

Nothing that I'm aware of. There is https://github.com/dawehner/drush_language though

@goba

This comment has been minimized.

Show comment
Hide comment
@goba

goba Oct 14, 2015

Yeah for Drupal 8 this would be core features to support, which is why I asked ;) I have a post at http://hojtsy.hu/blog/2013-jul-23/drupal-8-multilingual-tidbits-9-deployment-friendly-automated-downloads which refers to this issue for people to follow. If there is a better place to follow for D8 locale support, I would love to link to that.

goba commented Oct 14, 2015

Yeah for Drupal 8 this would be core features to support, which is why I asked ;) I have a post at http://hojtsy.hu/blog/2013-jul-23/drupal-8-multilingual-tidbits-9-deployment-friendly-automated-downloads which refers to this issue for people to follow. If there is a better place to follow for D8 locale support, I would love to link to that.

@gabooh

This comment has been minimized.

Show comment
Hide comment
@gabooh

gabooh Apr 28, 2016

Would love this issue to be reopened, locale commands in drush would be very useful.
Related forum post about why it could be useful : https://www.drupal.org/node/2715369

gabooh commented Apr 28, 2016

Would love this issue to be reopened, locale commands in drush would be very useful.
Related forum post about why it could be useful : https://www.drupal.org/node/2715369

@tstoeckler

This comment has been minimized.

Show comment
Hide comment
@tstoeckler

tstoeckler Apr 28, 2016

Contributor

Wow, I wasn't aware this issue even existed. Since #1817 (and #1818 resp.) we have drush locale-check and drush locale-update commands in Drush core. I use these regularly as part of a multilingual deployment workflow. Looking at http://cgit.drupalcode.org/l10n_update/tree/l10n_update.drush.inc what is missing is a drush locale-status command to bring this is inline with the D7 l10n_update module. I would be happy to review and merge a PR that adds that, not sure if I will get to it myself.

Contributor

tstoeckler commented Apr 28, 2016

Wow, I wasn't aware this issue even existed. Since #1817 (and #1818 resp.) we have drush locale-check and drush locale-update commands in Drush core. I use these regularly as part of a multilingual deployment workflow. Looking at http://cgit.drupalcode.org/l10n_update/tree/l10n_update.drush.inc what is missing is a drush locale-status command to bring this is inline with the D7 l10n_update module. I would be happy to review and merge a PR that adds that, not sure if I will get to it myself.

@gabooh

This comment has been minimized.

Show comment
Hide comment
@gabooh

gabooh Apr 28, 2016

@tstoeckler what is missing is a way to import po files. AFAIK I can't do that with drush locale-check and drush locale-update.
I've used drush_language mentionned above which worked perfectly.
Having this in drush core would make sense.

gabooh commented Apr 28, 2016

@tstoeckler what is missing is a way to import po files. AFAIK I can't do that with drush locale-check and drush locale-update.
I've used drush_language mentionned above which worked perfectly.
Having this in drush core would make sense.

@tstoeckler

This comment has been minimized.

Show comment
Hide comment
@tstoeckler

tstoeckler Apr 28, 2016

Contributor

Well you can in the sense that you can put PO files in the sites translation directory and then drush locale-update will find and import them. But you are right that there is no dedicated command to impor a single PO file explicitly. AFAICT that was not part of the D7 l10n_update Drush commands, either though, so I'm not sure that that is relevant to this issue.

I do think we should have commands to im- and export PO files in Drush core as that is functionality provided by the Drupal core locale module, even in Drupal 7. I even left a @todo to that effect in the code: https://github.com/drush-ops/drush/blob/master/commands/core/locale.d8.drush.inc#L37
Please open a separate issue for that, though.

Contributor

tstoeckler commented Apr 28, 2016

Well you can in the sense that you can put PO files in the sites translation directory and then drush locale-update will find and import them. But you are right that there is no dedicated command to impor a single PO file explicitly. AFAICT that was not part of the D7 l10n_update Drush commands, either though, so I'm not sure that that is relevant to this issue.

I do think we should have commands to im- and export PO files in Drush core as that is functionality provided by the Drupal core locale module, even in Drupal 7. I even left a @todo to that effect in the code: https://github.com/drush-ops/drush/blob/master/commands/core/locale.d8.drush.inc#L37
Please open a separate issue for that, though.

@gabooh

This comment has been minimized.

Show comment
Hide comment
@gabooh

gabooh Apr 29, 2016

Using the core `locale-update' feature is not straightforward. I've just figured it out. I've detailed that in this drupal forum post (https://www.drupal.org/node/2715369). It's just missing documentation in the end, works fine.

I've created #2164 anyway.
Thank you for your help.

gabooh commented Apr 29, 2016

Using the core `locale-update' feature is not straightforward. I've just figured it out. I've detailed that in this drupal forum post (https://www.drupal.org/node/2715369). It's just missing documentation in the end, works fine.

I've created #2164 anyway.
Thank you for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment