Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should remove the self-update command completely from Drush #167

Closed
greg-1-anderson opened this issue Sep 30, 2013 · 5 comments

Comments

@greg-1-anderson
Copy link
Member

commented Sep 30, 2013

The self-update command has not updated Drush since Drush 4; in Drush 5 and later, it only informs the user whether an update is available or not. Additionally, since the move to GitHub, self-update no longer works correctly, as it is still reporting on the availability of updates from drupal.org.

Since the current behavior of self-update was confusing for users even when it was working, and since it no longer works correctly at all, I suggest that we remove the command from the master, 6.x and 5.x branches. This breaks backwards compatibility, but since the command is not presently working anyway, I think that is preferable to leaving the broken version in.

The alternative would be to fix it, but I'm not terribly interested in doing that. If you agree that it should be removed, let me know and I'll take it out of 5.x and later.

c.f.: http://drupal.stackexchange.com/questions/87181/drush-gives-me-warning-fwrite-expects-parameter-1-to-be-resource

@jonhattan

This comment has been minimized.

Copy link
Member

commented Oct 1, 2013

+1. Users can subscribe to releases https://github.com/drush-ops/drush/releases.atom or follow @drushcli on twitter (it needs some love from our side).

greg-1-anderson added a commit that referenced this issue Oct 1, 2013
greg-1-anderson added a commit that referenced this issue Oct 1, 2013
greg-1-anderson added a commit that referenced this issue Oct 1, 2013
@greg-1-anderson

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2013

I added the link above to the README on master, 6.x, and 5.x.

@weitzman

This comment has been minimized.

Copy link
Member

commented Oct 3, 2013

I removed self-update late in the 6.x cycle so it should be gone from 6 and master already.

My expectation for 5.x is that this code would simply never notify you about 6. I found that to be acceptable failure. Sure, we could remove the command from 5 as well. if we are throwing errors, thats worse than I expected and should be fixed/removed.

@greg-1-anderson

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2013

I guess Jonhattan can yank this from 5.x if he wants, but I'm thinking that maybe the main people we'd want to help are those with older releases -- which of course we can't do anything about. Once you got a 5.11 from GitHub, you'd already know that Drush was on GitHub.

Re-open if you want, though.

@sinasalek

This comment has been minimized.

Copy link

commented Dec 31, 2014

Note that the easy way to install and update Drush is to use Composer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.