New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm-updatestatus broken in D8 #47

Closed
weitzman opened this Issue Aug 28, 2013 · 6 comments

Comments

Projects
None yet
2 participants
@weitzman
Member

weitzman commented Aug 28, 2013

Would be great if someone took this on. The issue is that D8 has changed. Not strictly a Drush issue.

~/htd/d8 (8.x=)$ dr ups
PHP Fatal error:  Call to undefined function _update_cache_clear() in /Users/moshe.weitzman/Dropbox/root/c/h/drush/commands/pm/update_info/drupal.inc on line 64
PHP Stack trace:
PHP   1. {main}() /Users/moshe.weitzman/Dropbox/root/c/h/drush/drush.php:0
PHP   2. drush_main() /Users/moshe.weitzman/Dropbox/root/c/h/drush/drush.php:16
PHP   3. _drush_bootstrap_and_dispatch() /Users/moshe.weitzman/Dropbox/root/c/h/drush/drush.php:61
PHP   4. drush_dispatch($command = *uninitialized*, $arguments = *uninitialized*) /Users/moshe.weitzman/Dropbox/root/c/h/drush/drush.php:92
PHP   5. call_user_func_array(*uninitialized*, *uninitialized*) /Users/moshe.weitzman/Dropbox/root/c/h/drush/includes/command.inc:182
PHP   6. drush_command() /Users/moshe.weitzman/Dropbox/root/c/h/drush/includes/command.inc:182
PHP   7. _drush_invoke_hooks($command = *uninitialized*, $args = *uninitialized*) /Users/moshe.weitzman/Dropbox/root/c/h/drush/includes/command.inc:214
PHP   8. call_user_func_array(*uninitialized*, *uninitialized*) /Users/moshe.weitzman/Dropbox/root/c/h/drush/includes/command.inc:362
PHP   9. drush_pm_updatestatus() /Users/moshe.weitzman/Dropbox/root/c/h/drush/includes/command.inc:362
PHP  10. _pm_get_update_info($projects = *uninitialized*) /Users/moshe.weitzman/Dropbox/root/c/h/drush/commands/pm/updatestatus.pm.inc:26

Once this is done, we will fix any bugs in pm-updatecode command.

@weitzman

This comment has been minimized.

Show comment
Hide comment
@weitzman

weitzman Dec 29, 2013

Member

Still busted. Anyone able to port this command?

Member

weitzman commented Dec 29, 2013

Still busted. Anyone able to port this command?

@weitzman

This comment has been minimized.

Show comment
Hide comment
@weitzman

weitzman Dec 29, 2013

Member

Some good info at https://drupal.org/node/2004154. Hopefully @jonhattan can take this on.

Member

weitzman commented Dec 29, 2013

Some good info at https://drupal.org/node/2004154. Hopefully @jonhattan can take this on.

weitzman added a commit that referenced this issue Dec 31, 2013

@weitzman

This comment has been minimized.

Show comment
Hide comment
@weitzman

weitzman Dec 31, 2013

Member

To see the test fail, run UNISH_DRUPAL_MAJOR_VERSION=8 phpunit --verbose pmUpdateCodeTest.php

Member

weitzman commented Dec 31, 2013

To see the test fail, run UNISH_DRUPAL_MAJOR_VERSION=8 phpunit --verbose pmUpdateCodeTest.php

@weitzman

This comment has been minimized.

Show comment
Hide comment
@weitzman

weitzman Aug 16, 2014

Member

Still busted. Any chance you can take a look, @jonhattan. We use a shell script now to run tests:

UNISH_DRUPAL_MAJOR_VERSION=8 ./unish.sh --filter=testUpdateCode

Member

weitzman commented Aug 16, 2014

Still busted. Any chance you can take a look, @jonhattan. We use a shell script now to run tests:

UNISH_DRUPAL_MAJOR_VERSION=8 ./unish.sh --filter=testUpdateCode

weitzman added a commit that referenced this issue Aug 24, 2014

Progress on #47.
I mostly commented out code and added $available = update_get_available(TRUE);

This will always grab latest data which I think is fine. However, the tests still fail. Help wanted.
@weitzman

This comment has been minimized.

Show comment
Hide comment
@weitzman

weitzman Aug 24, 2014

Member

I made a drupal7.inc so that drupal.inc could specialize for D8. Then I commented out some code and added $available = update_get_available(TRUE) just to try to get stuff working (see 58d844c). Not passing tests yet. Help wanted.

Member

weitzman commented Aug 24, 2014

I made a drupal7.inc so that drupal.inc could specialize for D8. Then I commented out some code and added $available = update_get_available(TRUE) just to try to get stuff working (see 58d844c). Not passing tests yet. Help wanted.

@jonhattan

This comment has been minimized.

Show comment
Hide comment
@jonhattan

jonhattan Sep 22, 2014

Member

Ported in 2ef580a

Member

jonhattan commented Sep 22, 2014

Ported in 2ef580a

@jonhattan jonhattan closed this Sep 22, 2014

serundeputy added a commit to serundeputy/drush that referenced this issue May 18, 2015

serundeputy added a commit to serundeputy/drush that referenced this issue Jul 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment