New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site install interactive #2485
Site install interactive #2485
Conversation
25278a8
to
5f324df
Compare
Yeah, this looks good in concept -- but why isn't the results from Travis showing up here? I looked briefly and did not see the tests. If you can demonstrate that the tests are passing, then I'd be okay with merging this, porting to 8.x, and then doing the annotated conversion as a follow-on step. If this were to be done to the annotated version of this command, |
Tests all green: +1 |
I just merged #2466, so this needs a re-roll.
|
ping @serundeputy |
073c8a3
to
effbd98
Compare
@weitzman thanks for the ping. I've refactored this agains the new master and I've got the prompts working but I'm confused about what I've set the options via prompts but it is bailing out with unrecoverable errors. Can you provide any insight? thanks, |
The only setOption() that you should need is on db-url. You can use regular local variables to briefly store stuff like password, host, etc. When you pass What errors are you seeing? |
Issue drush-ops#2484: Give site-install and interactive mode. Issue drush-ops#2484: Give site-install and interactive mode.
effbd98
to
0a0c5a8
Compare
Thanks @weitzman Manually tested on current D8 Manually tested on current D7
I think the D7 is a separate issue though. ~Geoff |
I moved the code around and then added this in 820fb5d. Thanks @serundeputy. Great to have some more interactivity in Drush. |
This could also have been done with |
#2484