Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes uname quoting #272

Closed
wants to merge 1 commit into from
Closed

Conversation

@barraponto
Copy link
Contributor

@barraponto barraponto commented Nov 18, 2013

Quoting a sub-shell avoids errors, but I'm not sure whether it works under windows 馃挬

@weitzman
Copy link
Member

@weitzman weitzman commented Nov 18, 2013

IIRC, we have been preferring backticks over $() as it is more universal. Perhaps @greg-1-anderson recalls the conversation there.

@greg-1-anderson
Copy link
Member

@greg-1-anderson greg-1-anderson commented Nov 18, 2013

Yes; $() is more readable, but `` works in more shells. The quotes added by the patch are very necessary, though; thank you for the PR.

@weitzman
Copy link
Member

@weitzman weitzman commented Nov 18, 2013

Can we implement a fix while still using backticks? Otherwise we are trading problems.

@greg-1-anderson
Copy link
Member

@greg-1-anderson greg-1-anderson commented Nov 18, 2013

It should be possible to just wrap the backticks in double quotes.

@weitzman weitzman closed this in de8658c Nov 18, 2013
weitzman added a commit that referenced this pull request Nov 19, 2013
greg-1-anderson added a commit that referenced this pull request Mar 27, 2015
greg-1-anderson added a commit that referenced this pull request Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.