fixes uname quoting #272

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@barraponto
Contributor

Quoting a sub-shell avoids errors, but I'm not sure whether it works under windows 💩

@weitzman
Member

IIRC, we have been preferring backticks over $() as it is more universal. Perhaps @greg-1-anderson recalls the conversation there.

@greg-1-anderson
Member

Yes; $() is more readable, but `` works in more shells. The quotes added by the patch are very necessary, though; thank you for the PR.

@weitzman
Member

Can we implement a fix while still using backticks? Otherwise we are trading problems.

@greg-1-anderson
Member

It should be possible to just wrap the backticks in double quotes.

@weitzman weitzman added a commit that closed this pull request Nov 18, 2013
@weitzman weitzman Fix #272. Fix quoting on newly added 'which uname' call by wrapping i…
…n double quotes.
de8658c
@weitzman weitzman closed this in de8658c Nov 18, 2013
@ahamid ahamid added a commit to ahamid/drush that referenced this pull request Nov 19, 2013
@ahamid ahamid fixes #272 (attempt 2) 3d3952c
@weitzman weitzman added a commit that referenced this pull request Nov 19, 2013
@ahamid @weitzman ahamid + weitzman fixes #272 (attempt 2) 5bbb61b
@greg-1-anderson greg-1-anderson added a commit that referenced this pull request Mar 27, 2015
@ahamid @greg-1-anderson ahamid + greg-1-anderson fixes #272 (attempt 2) b5443b1
@greg-1-anderson greg-1-anderson added a commit that referenced this pull request Mar 27, 2015
@ahamid @greg-1-anderson ahamid + greg-1-anderson fixes #272 (attempt 2) fe71b34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment