New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --result-file-auto to save to a date-based filename under ~/drush-backups directory #3370

Merged
merged 2 commits into from Feb 10, 2018

Conversation

Projects
None yet
2 participants
@hugovk
Copy link
Contributor

hugovk commented Feb 8, 2018

Fixes #3364.

Drush 9 has lost a Drush 8 feature:

  • If --result-file is provided with no value, then a date-based filename will be created under ~/drush-backups directory.

That's a really useful option for automated backups, but Symfony Console makes it hard to work with options that can be both Boolean and a string.

This PR adds a new --result-file-auto Boolean option to resurrect this.

If both --result-file and --result-file-auto are given, --result-file takes precedence.

image

Does something like this look like a possible solution to #3364?

@weitzman

This comment has been minimized.

Copy link
Member

weitzman commented Feb 8, 2018

Instead of a new option, maybe we just treat the value 'auto' as special? Seems better to me.

@hugovk

This comment has been minimized.

Copy link
Contributor Author

hugovk commented Feb 8, 2018

Yes, that sounds better. I'll update this.

@hugovk

This comment has been minimized.

Copy link
Contributor Author

hugovk commented Feb 8, 2018

Updated!

image

@hugovk hugovk closed this Feb 8, 2018

@hugovk hugovk deleted the hugovk:add--result-file-auto branch Feb 8, 2018

@hugovk hugovk restored the hugovk:add--result-file-auto branch Feb 8, 2018

@hugovk

This comment has been minimized.

Copy link
Contributor Author

hugovk commented Feb 8, 2018

Oops, I deleted this branch by accident, instead of another temporary one I'd made that removed the branch restriction from .travis.yml so I could test my feature branch on the CI.

Restored and reopened now, sorry about that!

@hugovk hugovk reopened this Feb 8, 2018

@weitzman weitzman merged commit 649109e into drush-ops:master Feb 10, 2018

5 checks passed

Shippable Run 154 status is SUCCESS.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_56 Your tests passed on CircleCI!
Details
ci/circleci: build_highest Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hugovk hugovk deleted the hugovk:add--result-file-auto branch Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment