Merged
Conversation
weitzman
approved these changes
Apr 27, 2022
Member
weitzman
left a comment
weitzman
left a comment
There was a problem hiding this comment.
LGTM. You prob noticed that our Highest test is still using Log2 - https://app.circleci.com/pipelines/github/drush-ops/drush/3868/workflows/6d7b5744-9924-445e-9891-2cc41b708f10/jobs/23550?invite=true#step-108-9
Member
Author
|
Yeah; to test, we need a Drupal 10 tag, branch or patch that allows psr/log ^3. With that, in theory, "highest" will install that version. |
Member
Author
|
Tested locally with https://github.com/greg-1-anderson/drupal-10-core-patched-psr-log-3. |
Member
Author
|
Drupal will hold us back to Robo ^3 until psr/log ^3 is allowed, so I will just merge this with the Robo ^4.0.0-alpha1 optional dependency until the Drupal psr/log ^3 patch is merged. Once that is confirmed working, I'll release a stable Robo 4. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Robo ^4 should allow Drush to use psr/log ^3 in contexts where Drupal 10 allows psr/log ^3.
Once confirmed, we can make a stable release of Robo 4.