Allow to set the URL for the security advisories composer url via env variable#5180
Merged
weitzman merged 4 commits intodrush-ops:11.xfrom Jul 12, 2022
Merged
Conversation
…ironment variable
Member
|
Seems reasonable.
|
Contributor
Author
|
@weitzman thank your for the fast feedback, really appreciate it. I made the changes you suggested. |
Member
|
I see that the tests are failing. Hopefully its a quick fix. |
Contributor
Author
|
Since getenv() returns FALSE instead of NULL if the env variable is not set or empty we propably have to stick with the ternary operator. |
weitzman
reviewed
Jul 12, 2022
Member
weitzman
left a comment
weitzman
left a comment
There was a problem hiding this comment.
yeah, i was thinking of ternary. here is a suggested change
Co-authored-by: Moshe Weitzman <weitzman@tejasa.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL which is used in the drush pm:security command is hard-coded and links to the drupal-security-advisories repo ( https://github.com/drupal-composer/drupal-security-advisories ). I really would like to have an easy option to use a different url if needed.
This PR sets the url for the source of the security check command to the environment variable DRUSH_SECURITY_ADVISORIES_URL if set, otherwise use the default url.