Allow downloading directly to a profile directory #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use profiles for your site builds drush has no way to download to the profile directory without adding a custom destination path on every drush call, this patch allows you to download directly to the profile when you are inside it's directory. If you are in the /profiles directory downloads fall back to default behaviour.
|
I see this to be of limited use. Basically only profile developers would use it. They can use --destination IMO |
|
This seems like a very odd response, even if it's of limited use, that doesn't mean it shouldn't be included if it doesn't break anything does it? |
|
Could you please reconsider this? using --destination doesn't respect the directory structure within the profile, eg if I download a theme it will get put in the directory set as the destination instead of the themes subdirectory of the profile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If you use profiles for your site builds drush has no way to download to the profile directory without adding a custom destination path on every drush call, this patch allows you to download directly to the profile when you are inside it's directory.
If you are in the /profiles directory downloads fall back to default behaviour.