Permalink
Browse files

Merge pull request #1033 from dcooper16/client_sim_data_tls13

TLS 1.3 clients in update_client_sim_data.pl
  • Loading branch information...
drwetter committed Apr 16, 2018
2 parents e38a30d + 639b1af commit 55adbf905fc7c19ac1601ae70beed46b18e3cce0
Showing with 11 additions and 1 deletion.
  1. +11 −1 utils/update_client_sim_data.pl
@@ -189,7 +189,17 @@
$sim->{protos} = "protos+=(\"" . (join " ", reverse @proto_flags) . "\")";
$sim->{tlsvers} = "tlsvers+=(\"" . (join " ", reverse @tls_flags) . "\")";
$sim->{lowestProtocol} = sprintf("lowest_protocol+=(\"0x%04x\")", $client->{lowestProtocol});
$sim->{highestProtocol} = sprintf("highest_protocol+=(\"0x%04x\")", $client->{highestProtocol});
# https://api.dev.ssllabs.com/api/v3/getClients incorrectly indicates
# a highestProtocol of TLS 1.2 for clients that support TLS 1.3, which
# can lead to client simulation reporting "no connection" if the connection
# is made using TLS 1.3. In order to avoid this problem, assume that any
# client with a highestProtocol of TLS 1.2 that supports any TLS 1.3
# ciphers really supports TLS 1.3.
if ( $client->{highestProtocol} != 771 || scalar(@ciphersuites) == 0 ) {
$sim->{highestProtocol} = sprintf("highest_protocol+=(\"0x%04x\")", $client->{highestProtocol});
} else {
$sim->{highestProtocol} = sprintf("highest_protocol+=(\"0x0304\")", $client->{highestProtocol});
}
if ( lc($client->{name}) eq "java" || lc($client->{name}) eq "openssl" ) {
# Java and OpenSSL are generic clients

0 comments on commit 55adbf9

Please sign in to comment.