Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect scanTime in JSON file with mass testing #1246

Open
dcooper16 opened this issue Apr 25, 2019 · 0 comments

Comments

@dcooper16
Copy link
Contributor

commented Apr 25, 2019

If mass testing is performed and a single JSON file is created for all of the results, then the final entry in the JSON file (scanTime) will be incorrect:

"scanTime"  : "Scan interrupted"

or

,         {
              "id"           : "scanTime",
              "ip"           : "/",
              "port"         : "443",
              "severity"     : "WARN",
              "finding"      : "Scan interrupted"
          }

The "Scan interrupted" occurs because fileout_json_footer() believes the scan was interrupted if SCAN_TIME is 0. This works in normal testing since SCAN_TIME is set at the end of lets_roll(). However, in mass testing lets_roll() isn't called (except to initialize) and so SCAN_TIME is never set.

Note also that in the case of the flat JSON output, the entry contains "ip" and "port", which are inappropriate since the entry is not specific to a particular server.

@drwetter drwetter added the minor bug label Apr 25, 2019
@drwetter drwetter added this to the 3.0 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.