Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Inconsistencies in run_protocols() #1343
Downgrade from TLS 1 ClientHello:
As is done in the
Downgrade from TLS 1.1 ClientHello:
Again, the printed output should note that the connection was downgraded (not just in debug mode). It should also be printed using
I also noticed that, at least in the case of a TLS 1.2 ClientHello, the rating is different for a return value of 3 or 4 than for a return value of 1, even though all three seem to be a result of the server rejecting the connection.
Finally, there is an inconsistency in the the rating when a server rejects a TLS 1.3 or TLS 1.2 ClientHello.
If a server rejects a TLS 1.2 ClientHello,
In addition to the above, the ratings for the "Negotiated protocol" in