Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one second for 825 day validity test #1450

Merged
merged 1 commit into from Jan 15, 2020
Merged

Add one second for 825 day validity test #1450

merged 1 commit into from Jan 15, 2020

Conversation

@drwetter
Copy link
Owner

drwetter commented Jan 15, 2020

The CA browser form agreed on a validity period of 825 days or less (https://cabforum.org/wp-content/uploads/CA-Browser-Forum-BR-1.5.3-redlined.pdf, p4).

PR #1427 addressed that. However when an issuer signed/issued a certificate with exactly 825 days, the check reported incorrectly that the life time is too long.

This PR addressed that by adding a second to the calculation. Also the output takes into account that it must be over ('>') 825 days, not '>='.

The CA browser form agreed on a validity period of 825 days or less
(https://cabforum.org/wp-content/uploads/CA-Browser-Forum-BR-1.5.3-redlined.pdf,
p4).

PR #1427 addressed that. However when an issuer signed/issued a certificate
with exactly 825 days, the check reported incorrectly that the life time
is too long.

This commit addressed that by adding a second to the calulation. Also the
output takes into account that it must be over ('>') 825 days, not '>='.
@drwetter drwetter merged commit 787e575 into 3.0 Jan 15, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@drwetter drwetter deleted the 826days_towarn branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.