Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds do-notation #1298

Merged
merged 5 commits into from Mar 7, 2022
Merged

Adds do-notation #1298

merged 5 commits into from Mar 7, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 27, 2022

I've decided that it is better to ship something than nothing 🙂
There are several things to do:

  • RequiresContext is special (second arg is not an error type)
  • RequiresContextResult support
  • RequiresContextFutureResult is also special, because we need async for as Future (but a bit different, because RequiresContextFutureResult is created as RequiresContextFutureResult(async def some(deps) -> Result[val, err]))

But, this is usable as-is for now! 🎉
Refs #392

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #1298 (81cb3d7) into master (d271806) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 81cb3d7 differs from pull request most recent head 87c1a46. Consider uploading reports for the commit 87c1a46 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1298   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines         2434      2487   +53     
  Branches       211       212    +1     
=========================================
+ Hits          2434      2487   +53     
Impacted Files Coverage Δ
returns/context/requires_context.py 100.00% <ø> (ø)
returns/future.py 100.00% <100.00%> (ø)
returns/io.py 100.00% <100.00%> (ø)
returns/maybe.py 100.00% <100.00%> (ø)
returns/result.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af347f4...87c1a46. Read the comment docs.

@sobolevn sobolevn merged commit cd08c2a into master Mar 7, 2022
@sobolevn sobolevn deleted the do-notation branch March 7, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant