Issue 1267 - Remove .success_type and .failure_type #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepabloaguilar
requested changes
Aug 31, 2023
typesafety/test_io/test_ioresult_container/test_ioresult_helpers.yml
Outdated
Show resolved
Hide resolved
Member
thepabloaguilar
left a comment
thepabloaguilar
left a comment
There was a problem hiding this comment.
Thanks for your contribution @ducdetronquito!
Codecov Report
@@ Coverage Diff @@
## master #1677 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 80 80
Lines 2497 2485 -12
Branches 437 437
=========================================
- Hits 2497 2485 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Hi @thepabloaguilar , Thank you for your review ! I made the requested changes in a dedicated commit to ease your review but if you prefer I can edit the original commits. Have a nice day ! |
sobolevn
reviewed
Aug 31, 2023
CHANGELOG.md
Outdated
|
|
||
| ### Misc | ||
|
|
||
| - *Breaking*: Remove `Result.success_type` and `Result.failure_type` |
Member
There was a problem hiding this comment.
Let's list all removed items in a single point
Contributor
Author
There was a problem hiding this comment.
I made the change in a new commit
sobolevn
reviewed
Aug 31, 2023
CHANGELOG.md
Outdated
| See [0Ver](https://0ver.org/). | ||
|
|
||
|
|
||
| ## 0.23.0 WIP |
Contributor
Author
There was a problem hiding this comment.
Done deal :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
.success_typeand.failure_type#1267The process to start contributing is very clear: it's nice when it's easy to get started :)