New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize rspec configuration #24

Merged
merged 2 commits into from Sep 1, 2016

Conversation

Projects
None yet
2 participants
@ivoanjo
Copy link
Collaborator

ivoanjo commented Sep 1, 2016

While I'm on a roll, I've been submitting similar PRs to some of the gems I use, so let's do it for dry-container too :)

This PR updates the project's spec_helper with the current defaults obtained by generating a new spec_helper with rspec --init. Modern rspec releases have a lot of useful options that are turned off
by default for backwards compatibility reasons, but that are rather useful, so a newly-created configuration includes their currently-recommended defaults.

ivoanjo added some commits Sep 1, 2016

Modernize rspec configuration
Generated a new spec_helper with rspec --init (after renaming the old
one) and merged with the existing spec_helper.

Modern rspec releases have a lot of useful options that are turned off
by default for backwards compatibility reasons, but that are rather
useful, so a newly-created configuration includes their
currently-recommended defaults.
Disable rspec's monkey patching
By running with monkey patching, specs are executed in a much cleaner
environment (e.g. one which does not include rspec's monkey patches to
core ruby libraries) that more closely resembles real-world use.
@AMHOL

This comment has been minimized.

Copy link
Member

AMHOL commented Sep 1, 2016

@AMHOL AMHOL merged commit 4947b98 into master Sep 1, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@AMHOL AMHOL deleted the modernize-rspec-configuration branch Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment