Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback to_hash deprecation #149

Merged
merged 2 commits into from Feb 2, 2020
Merged

Conversation

@flash-gordon
Copy link
Member

flash-gordon commented Feb 2, 2020

@solnic it's implicitly used by rom-changeset here https://github.com/rom-rb/rom/blob/212ccab204c49b64f8d81e03b6b3dc7c041d1182/changeset/lib/rom/changeset/update.rb#L68
It shouldn't be hard to fix if we change auto_struct to false for original, I'll file an issue there. For the time being, I'm rolling back the deprecation.

flash-gordon added 2 commits Feb 2, 2020
@dry-bot

This comment has been minimized.

Copy link
Contributor

dry-bot commented Feb 2, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 1
           

See the complete overview on Codacy

@@ -159,7 +159,8 @@ def to_h
result[key.name] = Hashify[self[key.name]] if attributes.key?(key.name)
end
end
deprecate :to_hash, :to_h, message: "Implicit convertion structs to hashes is deprecated. Use .to_h"
alias_method :to_hash, :to_h
# deprecate :to_hash, :to_h, message: "Implicit convertion structs to hashes is deprecated. Use .to_h"

This comment has been minimized.

Copy link
@dry-bot
@flash-gordon flash-gordon merged commit 65f8d35 into master Feb 2, 2020
15 of 16 checks passed
15 of 16 checks passed
tests (2.7)
Details
tests (2.7)
Details
tests (2.7)
Details
tests (2.6)
Details
tests (2.6)
Details
tests (2.6)
Details
tests (2.5)
Details
tests (2.5)
Details
tests (2.5)
Details
tests (2.4)
Details
tests (2.4)
Details
tests (2.4)
Details
tests (jruby)
Details
tests (jruby)
Details
tests (jruby)
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
@flash-gordon flash-gordon deleted the rollback-to_hash-deprecation branch Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.