Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build constructors when class implementing type interface given #371

Merged
merged 1 commit into from Nov 17, 2019

Conversation

@flash-gordon
Copy link
Member

flash-gordon commented Nov 10, 2019

There is no point in doing this. Moreover, Dry::Struct::Constructor doesn't implement all type methods (for some reasons, I guess) and it led to regressions in hanami-model.

There is no point in doing this. Moreover, Dry::Struct::Constructor doesn't implement all type methods (for some reasons, I guess) and it led to regressions in hanami-model.
@flash-gordon flash-gordon merged commit c80dc3b into master Nov 17, 2019
12 of 13 checks passed
12 of 13 checks passed
tests-mri (2.6.x, true)
Details
tests-mri (2.6.x, false)
Details
tests-mri (2.5.x, true)
Details
tests-mri (2.5.x, false)
Details
tests-mri (2.4.x, true)
Details
tests-mri (2.4.x, false)
Details
tests-others (jruby:9.2.8, true)
Details
tests-others (jruby:9.2.8, false)
Details
tests-others (ruby:rc, true)
Details
tests-others (ruby:rc, false)
Details
codeclimate 3 issues to fix
Details
codeclimate/diff-coverage 100% (80% threshold)
Details
codeclimate/total-coverage 96% (0.0% change)
Details
@flash-gordon flash-gordon deleted the no-rewrap-for-structs branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.