Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse list tokens as comma separated list in msgs #611

Merged
merged 1 commit into from Jan 6, 2020
Merged

Conversation

@waiting-for-dev
Copy link
Member

waiting-for-dev commented Jan 5, 2020

Fixes #609

Fixes #609
@solnic solnic merged commit 12b3518 into master Jan 6, 2020
32 of 33 checks passed
32 of 33 checks passed
tests (2.6, false, false)
Details
tests-mri (2.6.x, false, false)
Details
tests (2.6, false, true)
Details
tests-mri (2.6.x, false, true)
Details
tests (2.6, true, false)
Details
tests-mri (2.6.x, true, false)
Details
tests (2.6, true, true)
Details
tests-mri (2.6.x, true, true)
Details
tests (2.5, false, false)
Details
tests-mri (2.5.x, false, false)
Details
tests (2.5, false, true)
Details
tests-mri (2.5.x, false, true)
Details
tests (2.5, true, false)
Details
tests-mri (2.5.x, true, false)
Details
tests (2.5, true, true)
Details
tests-mri (2.5.x, true, true)
Details
tests (2.4, false, false)
Details
tests-mri (2.4.x, false, false)
Details
tests (2.4, false, true)
Details
tests-mri (2.4.x, false, true)
Details
tests (2.4, true, false)
Details
tests-mri (2.4.x, true, false)
Details
tests (2.4, true, true)
Details
tests-mri (2.4.x, true, true)
Details
tests-jruby (false, false)
Details
tests-jruby (false, true) tests-jruby (false, true)
Details
tests-jruby (true, false)
Details
tests-jruby (true, true)
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Hound No violations found. Woof!
codeclimate All good!
Details
codeclimate/diff-coverage 100% (99% threshold)
Details
codeclimate/total-coverage 99%
Details
@solnic solnic deleted the array_opt_msgs_rule branch Jan 6, 2020
@solnic

This comment has been minimized.

Copy link
Member

solnic commented Jan 6, 2020

@waiting-for-dev thanks! could you update the CHANGELOG.md in master?

waiting-for-dev added a commit that referenced this pull request Jan 7, 2020
@waiting-for-dev

This comment has been minimized.

Copy link
Member Author

waiting-for-dev commented Jan 7, 2020

hey @solnic , changelog updated!

@solnic

This comment has been minimized.

Copy link
Member

solnic commented Jan 7, 2020

@waiting-for-dev sweet, thank you :) btw I have an idea to automate that - we could establish a PR template with a special section for a changelog entry and then, after the PR is merged, a GH action could extract the entry and update the CHANGELOG file.

@waiting-for-dev

This comment has been minimized.

Copy link
Member Author

waiting-for-dev commented Jan 7, 2020

That would be super cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.