Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance benchmarking CI step failure reflects as success #56

Closed
countvajhula opened this issue Jul 22, 2022 · 1 comment
Closed
Labels
developer Relevant only to Qi developers

Comments

@countvajhula
Copy link
Collaborator

When the benchmarks step fails, it still returns a success error code, and the job only fails on the next step, obscuring the source of the problem, like in this example.

See this conversation for more context. Excerpts:

"the | used in this command obscures the error result of the first command in the pipeline. Should be able to fix this in the future: https://unix.stackexchange.com/questions/14270/get-exit-status-of-process-thats-piped-to-another"

"yea, I suspect set -o pipefail is what you want for that."

@countvajhula countvajhula added the developer Relevant only to Qi developers label Jul 22, 2022
@countvajhula
Copy link
Collaborator Author

Considering this closed unless we discover otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Relevant only to Qi developers
Projects
None yet
Development

No branches or pull requests

1 participant