Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial test suite #3

Merged
merged 3 commits into from Apr 9, 2020
Merged

Initial test suite #3

merged 3 commits into from Apr 9, 2020

Conversation

@openstrike
Copy link
Contributor

@openstrike openstrike commented Sep 6, 2018

Here are some tests for the dist. They are pretty basic but hopefully may help to catch some regressions.

I've been assigned Alien::Gnuplot this month as part of the CPAN PR Challenge and this PR is submitted as part of that.

Unless you have anything particular in mind for the dist, I will look to address some of the other kwalitee issues.

@drzowie
Copy link
Owner

@drzowie drzowie commented Sep 6, 2018

@openstrike
Copy link
Contributor Author

@openstrike openstrike commented Apr 9, 2020

Is there anything further you need on this PR in order to merge?

Thanks.

Copy link
Collaborator

@mohawk2 mohawk2 left a comment

Soon as you update these points, I will be happy to merge and release!

t/00-use.t Outdated Show resolved Hide resolved
Makefile.PL Outdated Show resolved Hide resolved
openstrike added 2 commits Apr 9, 2020
Do not test specific version number
Tidy 00-use.t
@mohawk2
mohawk2 approved these changes Apr 9, 2020
@mohawk2 mohawk2 merged commit 4df252b into drzowie:master Apr 9, 2020
@mohawk2
Copy link
Collaborator

@mohawk2 mohawk2 commented Apr 9, 2020

Thanks! Given it's only tests, I won't actually cut a release. That would need some actual features - want to step up? :-)

@mohawk2
Copy link
Collaborator

@mohawk2 mohawk2 commented Apr 9, 2020

For instance, it would be very valuable to add some CI - Travis or GitHub workflows for instance.

@openstrike
Copy link
Contributor Author

@openstrike openstrike commented Apr 9, 2020

It seems that someone is already taking care of Travis integration: https://github.com/amba/Alien-Gnuplot/tree/travis-test

@mohawk2
Copy link
Collaborator

@mohawk2 mohawk2 commented Apr 9, 2020

Given the last commit was mid-2018, I think it's ripe for someone (you?) to copy and take ownership of :-)

@drzowie
Copy link
Owner

@drzowie drzowie commented Apr 9, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.